svn commit: r300557 - head/usr.sbin/apmd

[John Baldwin]

On Monday, May 23, 2016 09:24:41 PM Alan Somers wrote:
> On Mon, May 23, 2016 at 9:15 PM, Peter Wemm <peter at freebsd.org> wrote:
> 
> > Author: peter
> > Date: Tue May 24 03:15:46 2016
> > New Revision: 300557
> > URL: https://svnweb.freebsd.org/changeset/base/300557
> >
> > Log:
> >   It seems <sys/types.h> is a new prerequisite for <bitstring.h> after
> >   r300539. Attempt to fix the build for i386.
> >
> > Modified:
> >   head/usr.sbin/apmd/apmd.c
> >   head/usr.sbin/apmd/apmdlex.l
> >   head/usr.sbin/apmd/apmdparse.y
> >
> >
> Are you sure this is necessary, even after 300544?

Actually, we try to avoid nested includes when possible for userland, so I'd
be inclined to drop the <sys/types.h> nested include and just add
<sys/types.h> to the places that need it.  Userland code in the base system
is supposed to have <sys/types.h> or <sys/param.h> as the first #include
anyway (which apmd was not following), so any fixes to userland are probably
style fixes anyway.

-- 
John Baldwin