svn commit: r300113 - in head/sys: conf kern net sys

Bjoern A. Zeeb bzeeb-lists at lists.zabbadoz.net
Wed May 18 11:01:52 UTC 2016


> On 18 May 2016, at 04:35 , Scott Long <scottl at FreeBSD.org> wrote:
> 
> Author: scottl
> Date: Wed May 18 04:35:58 2016
> New Revision: 300113
> URL: https://svnweb.freebsd.org/changeset/base/300113
> 
> Log:
>  Import the 'iflib' API library for network drivers.  From the author:
> 
>  "iflib is a library to eliminate the need for frequently duplicated device
>  independent logic propagated (poorly) across many network drivers."
> 
>  Participation is purely optional.  The IFLIB kernel config option is
>  provided for drivers that want to transition between legacy and iflib
>  modes of operation.  ixl and ixgbe driver conversions will be committed
>  shortly.  We hope to see participation from the Broadcom and maybe
>  Chelsio drivers in the near future.
> 
>  Submitted by:   mmacy at nextbsd.org
>  Reviewed by:    gallatin
>  Differential Revision:  D5211
> 
> Added:
>  head/sys/net/ifdi_if.m   (contents, props changed)
>  head/sys/net/iflib.c   (contents, props changed)
>  head/sys/net/iflib.h   (contents, props changed)
>  head/sys/net/mp_ring.c   (contents, props changed)
>  head/sys/net/mp_ring.h   (contents, props changed)
> Modified:
>  head/sys/conf/files
>  head/sys/conf/options
>  head/sys/kern/device_if.m
>  head/sys/kern/kern_mbuf.c
>  head/sys/kern/subr_taskqueue.c
>  head/sys/net/if.c
>  head/sys/net/if_var.h
>  head/sys/sys/_task.h
>  head/sys/sys/mbuf.h
>  head/sys/sys/taskqueue.h

Ignoring style for a moment, this broke builds;

just as examples:  mips XLP

cc1: warnings being treated as errors
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c: In function 'drain_ring_lockless':
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c:204: warning: implicit declaration of function 'atomic_cmpset_64'
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c:204: warning: nested extern declaration of 'atomic_cmpset_64' [-Wnested-externs]
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c:231: warning: implicit declaration of function 'atomic_cmpset_acq_64'
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c:231: warning: nested extern declaration of 'atomic_cmpset_acq_64' [-Wnested-externs]
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c: In function 'ifmp_ring_enqueue':
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c:456: warning: implicit declaration of function 'atomic_cmpset_rel_64'
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c:456: warning: nested extern declaration of 'atomic_cmpset_rel_64' [-Wnested-externs]
--- mp_ring.o ---
*** [mp_ring.o] Error code 1

bmake[5]: stopped in /storage/head/obj/mips.mips/scratch/tmp/bz/head.svn/sys/XLP


powerpc LINT:

cc1: warnings being treated as errors
/scratch/tmp/bz/head.svn/sys/net/iflib.c: In function '_iflib_fl_refill':
/scratch/tmp/bz/head.svn/sys/net/iflib.c:1538: warning: comparison is always true due to limited range of data type
/scratch/tmp/bz/head.svn/sys/net/iflib.c: In function 'iflib_fl_bufs_free':
/scratch/tmp/bz/head.svn/sys/net/iflib.c:1667: warning: comparison is always true due to limited range of data type
--- iflib.o ---
*** [iflib.o] Error code 1

bmake[5]: stopped in /storage/head/obj/powerpc.powerpc/scratch/tmp/bz/head.svn/sys/LINT
cc1: warnings being treated as errors
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c: In function 'drain_ring_lockless':
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c:204: warning: implicit declaration of function 'atomic_cmpset_64'
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c:204: warning: nested extern declaration of 'atomic_cmpset_64' [-Wnested-externs]
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c:231: warning: implicit declaration of function 'atomic_cmpset_acq_64'
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c:231: warning: nested extern declaration of 'atomic_cmpset_acq_64' [-Wnested-externs]
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c: In function 'ifmp_ring_enqueue':
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c:456: warning: implicit declaration of function 'atomic_cmpset_rel_64'
/scratch/tmp/bz/head.svn/sys/net/mp_ring.c:456: warning: nested extern declaration of 'atomic_cmpset_rel_64' [-Wnested-externs]
--- mp_ring.o ---
*** [mp_ring.o] Error code 1

…




— 
Bjoern A. Zeeb                                  Charles Haddon Spurgeon:
"Friendship is one of the sweetest joys of life.  Many might have failed
 beneath the bitterness of their trial  had they not found a friend."



More information about the svn-src-head mailing list