svn commit: r299753 - head/sys/fs/fuse

Rick Macklem rmacklem at uoguelph.ca
Mon May 16 22:56:38 UTC 2016


Alexey Dokuchaev wrote:
> On Sat, May 14, 2016 at 08:03:22PM +0000, Rick Macklem wrote:
> > New Revision: 299753
> > URL: https://svnweb.freebsd.org/changeset/base/299753
> > 
> > Log:
> >   Fix fuse to use DIRECT_IO when required.
> >   
> >   When a file is opened write-only and a partial block was written,
> >   buffered I/O would try and read the whole block in. This would
> >   result in a hung thread, since there was no open (fuse filehandle)
> >   that allowed reading. This patch avoids the problem by forcing
> >   DIRECT_IO for this case.
> >   It also sets DIRECT_IO when the file system specifies the FN_DIRECTIO
> >   flag in its reply to the open.
> 
> Since you're at fuse now, perhaps you could also have a look at PR 195000?
> 
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195000
> 
> ./danfe
> 
I was able to test the patch and it stops the crash.
I took out the MPASS() call because I didn't see why it should panic
for VFIFO instead of returning EINVAL like the rest.

If you'd like to commit it, email soon. Otherwise I will commit it.

Thanks for pointing this out, rick


More information about the svn-src-head mailing list