svn commit: r299869 - head/usr.sbin/route6d

Don Lewis truckman at FreeBSD.org
Sun May 15 22:31:04 UTC 2016


Author: truckman
Date: Sun May 15 22:31:03 2016
New Revision: 299869
URL: https://svnweb.freebsd.org/changeset/base/299869

Log:
  Use strlcpy() instead of strncpy() when copying ifname to ensure
  that it is NUL terminated.  Additional NUL padding is not required
  for short names.
  
  Reported by:	Coverity
  CID:		1009974
  MFC after:	1 week

Modified:
  head/usr.sbin/route6d/route6d.c

Modified: head/usr.sbin/route6d/route6d.c
==============================================================================
--- head/usr.sbin/route6d/route6d.c	Sun May 15 22:17:41 2016	(r299868)
+++ head/usr.sbin/route6d/route6d.c	Sun May 15 22:31:03 2016	(r299869)
@@ -1592,7 +1592,7 @@ ifconfig1(const char *name,
 	if (IN6_IS_ADDR_SITELOCAL(&sin6->sin6_addr) && !lflag)
 		return (-1);
 	ifr.ifr_addr = *sin6;
-	strncpy(ifr.ifr_name, name, sizeof(ifr.ifr_name));
+	strlcpy(ifr.ifr_name, name, sizeof(ifr.ifr_name));
 	if (ioctl(s, SIOCGIFNETMASK_IN6, (char *)&ifr) < 0) {
 		syslog(LOG_INFO, "ioctl: SIOCGIFNETMASK_IN6");
 		return (-1);


More information about the svn-src-head mailing list