svn commit: r299839 - head/etc/rc.d

Ian Lepore ian at freebsd.org
Sun May 15 16:46:01 UTC 2016


On Sun, 2016-05-15 at 04:38 +0000, Garrett Cooper wrote:
> Author: ngie
> Date: Sun May 15 04:38:50 2016
> New Revision: 299839
> URL: https://svnweb.freebsd.org/changeset/base/299839
> 
> Log:
>   Make FILESYSTEMS, dumpon, and var not depend on zfs and zvol
>   
>   Make zfs and zvol come before all of the items that depended on
> them
>   previously
>   

I'm trying to figure out why these changes are needed.  rcorder works
just fine when a requirement has no providers (yes, it whines, but
that's why /etc/rc invokes it with 2>/dev/null).  If FILESYSTEMS
requires zfs and nothing provides zfs, then it's as if the requirement
weren't in the list at all.

The manpage for rcorder is wrong, the DIAGNOSTICS section implies that
rcorder will abort on a missing requirement, but it doesn't.

Changing requirements to BEFOREs seems like it has a lot of potential
for messing with peoples' out-of-tree customizations.  (And for some
reason I've always had the impression that BEFORE was to be avoided in
the base rc files, but I can't remember why I think that.)

-- Ian



More information about the svn-src-head mailing list