svn commit: r299480 - head/secure/lib/libcrypto

[Jung-uk Kim]

On 05/11/16 04:43 PM, Ed Maste wrote:
> On 11 May 2016 at 16:06, Jung-uk Kim <jkim at freebsd.org> wrote:
>> Author: jkim
>> Date: Wed May 11 20:06:23 2016
>> New Revision: 299480
>> URL: https://svnweb.freebsd.org/changeset/base/299480
>>
> [...]
>>         ( echo '# $$'FreeBSD'$$' ;\
>>         echo '# Do not modify. This file is auto-generated from ${.IMPSRC:T}.' ;\
>>         echo '#ifdef PIC' ;\
>> -       perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} -fpic -DPIC ;\
>> +       env CC=cc perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} -fpic -DPIC ;\
>>         echo '#else' ;\
>> -       perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} ;\
>> +       env CC=cc perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} ;\
> 
> One thing that occurred to me in the older PIC change here: perhaps we
> should explicitly strip -fpic / -DPIC from the passed-in ${CFLAGS} for
> the #else. It's unlikely, but possible, that a user could regenerate
> the assembly files with -fpic set in CFLAGS.

No user serviceable parts inside. ;-)

Seriously, there's no need for overengineering this file.

Jung-uk Kim

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20160511/ea97c755/attachment.sig>