svn commit: r299363 - head/sys/compat/linuxkpi/common/include/asm

John Baldwin jhb at freebsd.org
Tue May 10 15:56:10 UTC 2016


On Tuesday, May 10, 2016 05:06:08 PM Hans Petter Selasky wrote:
> On 05/10/16 13:39, Hans Petter Selasky wrote:
> > Author: hselasky
> > Date: Tue May 10 11:39:36 2016
> > New Revision: 299363
> > URL: https://svnweb.freebsd.org/changeset/base/299363
> >
> > Log:
> >   Use function macros when possible to avoid stray substitutions.
> >
> >   MFC after:	1 week
> >   Sponsored by:	Mellanox Technologies
> >
> 
> FYI
> 
> This change accidentially broke LINT and I have a patch waiting for 
> review from the Chelsio guys that will fix LINT and WITH_OFED=YES again. 
> Will hopefully be fixed shortly.

Is the reason for the change to avoid accepting the wrong number of arguments
(e.g. cpu_to_be32(x, y))?  Won't that still fail to compile if so?  (That is,
the reasoning for why you made the original change isn't clear to me from the
commit.)

-- 
John Baldwin


More information about the svn-src-head mailing list