svn commit: r298950 - head/sys/dev/pci

John Baldwin jhb at FreeBSD.org
Tue May 3 00:35:13 UTC 2016


Author: jhb
Date: Tue May  3 00:35:11 2016
New Revision: 298950
URL: https://svnweb.freebsd.org/changeset/base/298950

Log:
  Fix an off by one error when remapping MSI-X vectors.
  
  pci_remap_msix() can be used to alter the mapping of allocated
  MSI-X vectors to the MSI-X table.  The code had an off by one error
  when adding the IRQ resources after performing a remap.  This was
  fatal for any vectors in the table that used the "last" valid IRQ as
  those vectors were assigned a garbage IRQ value.
  
  MFC after:	3 days

Modified:
  head/sys/dev/pci/pci.c

Modified: head/sys/dev/pci/pci.c
==============================================================================
--- head/sys/dev/pci/pci.c	Tue May  3 00:09:13 2016	(r298949)
+++ head/sys/dev/pci/pci.c	Tue May  3 00:35:11 2016	(r298950)
@@ -1855,7 +1855,7 @@ pci_remap_msix_method(device_t dev, devi
 	for (i = 0; i < count; i++) {
 		if (vectors[i] == 0)
 			continue;
-		irq = msix->msix_vectors[vectors[i]].mv_irq;
+		irq = msix->msix_vectors[vectors[i] - 1].mv_irq;
 		resource_list_add(&dinfo->resources, SYS_RES_IRQ, i + 1, irq,
 		    irq, 1);
 	}
@@ -1869,7 +1869,7 @@ pci_remap_msix_method(device_t dev, devi
 				printf("---");
 			else
 				printf("%d",
-				    msix->msix_vectors[vectors[i]].mv_irq);
+				    msix->msix_vectors[vectors[i] - 1].mv_irq);
 		}
 		printf("\n");
 	}


More information about the svn-src-head mailing list