svn commit: r298924 - head/usr.bin/sdiff

Conrad Meyer cem at FreeBSD.org
Mon May 2 16:08:36 UTC 2016


On Mon, May 2, 2016 at 8:57 AM, Benjamin Kaduk <bjkfbsd at gmail.com> wrote:
> On Mon, May 2, 2016 at 10:54 AM, Bjoern A. Zeeb <bz at freebsd.org> wrote:
>> > On 02 May 2016, at 15:32 , Conrad Meyer <cem at FreeBSD.org> wrote:
>> >
>> > Clang should really catch this too.  Why didn’t it?
>>
>> It was only powerpc;  sparc64 and mips were good as well.
>
> 'char' being signed vs. unsigned?

Yeah, that occurred to me, but EOF should be out of range for any char
type.  I'd like ((char)getchar() == EOF) to warn on all platforms.

Best,
Conrad


More information about the svn-src-head mailing list