svn commit: r298890 - in head/sys: dev/firewire i386/bios sys

Konstantin Belousov kib at FreeBSD.org
Sun May 1 17:46:58 UTC 2016


Author: kib
Date: Sun May  1 17:46:56 2016
New Revision: 298890
URL: https://svnweb.freebsd.org/changeset/base/298890

Log:
  Make it explicit that D_MEM cdevsw d_flag is to signify that the
  driver is (or behaves identically to) /dev/mem.  Remove the D_MEM flag
  from random drivers.
  
  Note that currently the D_MEM flag does not affect any behaviour, but
  this going to change in the next commit.
  
  Noted and reviewed by:	alc
  Sponsored by:	The FreeBSD Foundation
  MFC after:	1 week
  X-Differential revision:	https://reviews.freebsd.org/D6149

Modified:
  head/sys/dev/firewire/fwdev.c
  head/sys/i386/bios/smapi.c
  head/sys/sys/conf.h

Modified: head/sys/dev/firewire/fwdev.c
==============================================================================
--- head/sys/dev/firewire/fwdev.c	Sun May  1 16:49:32 2016	(r298889)
+++ head/sys/dev/firewire/fwdev.c	Sun May  1 17:46:56 2016	(r298890)
@@ -80,7 +80,6 @@ struct cdevsw firewire_cdevsw = {
 	.d_mmap =	fw_mmap,
 	.d_strategy =	fw_strategy,
 	.d_name =	"fw",
-	.d_flags =	D_MEM
 };
 
 struct fw_drv1 {

Modified: head/sys/i386/bios/smapi.c
==============================================================================
--- head/sys/i386/bios/smapi.c	Sun May  1 16:49:32 2016	(r298889)
+++ head/sys/i386/bios/smapi.c	Sun May  1 17:46:56 2016	(r298890)
@@ -80,7 +80,7 @@ static struct cdevsw smapi_cdevsw = {
 	.d_version =	D_VERSION,
 	.d_ioctl =	smapi_ioctl,
 	.d_name =	"smapi",
-	.d_flags =	D_MEM | D_NEEDGIANT,
+	.d_flags =	D_NEEDGIANT,
 };
 
 static void	smapi_identify(driver_t *, device_t);

Modified: head/sys/sys/conf.h
==============================================================================
--- head/sys/sys/conf.h	Sun May  1 16:49:32 2016	(r298889)
+++ head/sys/sys/conf.h	Sun May  1 17:46:56 2016	(r298890)
@@ -138,7 +138,7 @@ typedef int dumper_t(
 #define	D_TAPE	0x0001
 #define	D_DISK	0x0002
 #define	D_TTY	0x0004
-#define	D_MEM	0x0008
+#define	D_MEM	0x0008	/* /dev/(k)mem */
 
 #ifdef _KERNEL
 


More information about the svn-src-head mailing list