svn commit: r297315 - head/etc/rc.d

Ian Lepore ian at freebsd.org
Sun Mar 27 20:38:07 UTC 2016


On Sun, 2016-03-27 at 12:46 -0700, Ngie Cooper (yaneurabeya) wrote:
> > On Mar 27, 2016, at 10:22, Kristof Provost <kp at FreeBSD.org> wrote:
> > 
> > Author: kp
> > Date: Sun Mar 27 17:22:27 2016
> > New Revision: 297315
> > URL: https://svnweb.freebsd.org/changeset/base/297315
> 
>> 
> > Modified: head/etc/rc.d/pf
> > ===================================================================
> > ===========
> > --- head/etc/rc.d/pf	Sun Mar 27 16:27:49 2016	(r29731
> > 4)
> > +++ head/etc/rc.d/pf	Sun Mar 27 17:22:27 2016	(r29731
> > 5)
> > @@ -66,7 +66,11 @@ pf_resync()
> > 
> > pf_status()
> > {
> > -	$pf_program -s info
> > +	if ! [ -c /dev/pf ] ; then
> > +		echo "pf.ko is not loaded"
> > +	else
> > +		$pf_program -s info
> > +	fi
> 
> This might be better:
> 
> load_kld pf || return 1
> $pf_program -s info
> 

Having a status command say "module is not loaded" makes more sense to
me than having it load the module so that it could tell you that pf is
not active (which must surely be the bottom-line status if the module
wasn't loaded to begin with).

-- Ian



More information about the svn-src-head mailing list