svn commit: r296320 - in head/sys: kern sys

[Hans Petter Selasky]

On 03/03/16 12:27, Konstantin Belousov wrote:
>> >BTW: The FreeBSD kernel version should have been bumped because
>> >_callout_stop_safe() is a public callout API, used by all external
>> >kernel modules, which now will have undefined behaviour until recompiled.
> The change was done in a way which is compatible with the pre-commit
> callout_stop_safe(9)  users.  I even consider it mergeable into the
> stable/10 without requiring any shims.
>
>

Yes, your change is compatible if you compile the code, but not binary 
compatible. See the following macros, and how they use _callout_stop_safe():

#define callout_stop(c)         _callout_stop_safe(c, 0, NULL)
#define callout_async_drain(c, d)                                       \
     _callout_stop_safe(c, 0, d)

Because callout_stop(c) is a macro, you've now change the API for 
callout_stop() aswell. This is what I think will break binary 
compatibility in 10.x.

That's why the need to bump __FreeBSD_version__

--HPS