svn commit: r296299 - head/sys/contrib/ipfilter/netinet

[Cy Schubert]

In message <CAOfEmZieRiDf6U+oEReazj9JvRu1mNgAj1F--6J0usi=dDXNyw at mail.gmail.c
om>
, Marcelo Araujo writes:
> --001a113c48b0b9a687052d08a983
> 2016-03-02 11:40 GMT+08:00 Don Lewis <truckman at freebsd.org>:
> 
> > On  2 Mar, Cy Schubert wrote:
> > > Author: cy
> > > Date: Wed Mar  2 03:28:57 2016
> > > New Revision: 296299
> > > URL: https://svnweb.freebsd.org/changeset/base/296299
> > >
> > > Log:
> > >   Remove redundant NULL pointer comparison.
> > >
> > >   Reported  by:               PVS-Studio (V595) in D5245
> > >   Differential Revision:      D5245
> > >
> > > Modified:
> > >   head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c
> > >
> > > Modified: head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c
> > >
> > ===========================================================================
> ===
> > > --- head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c    Wed Mar  2
> > 03:26:56 2016        (r296298)
> > > +++ head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c    Wed Mar  2
> > 03:28:57 2016        (r296299)
> > > @@ -1951,10 +1951,6 @@ ipf_p_ftp_epsv(softf, fin, ip, nat, ftp,
> > >               ap += *s++ - '0';
> > >       }
> > >
> > > -     if (!s) {
> > > -             return 0;
> > > -}
> > > -
> > >       if (*s == '|')
> > >               s++;
> > >       if (*s == ')')
> > >
> >
> > I wonder if that test was meant to be:
> >         if (!*s) {
> > especially since hitting the end of the string terminates the preceeding
> > loop?
> >
> >
> >
> +1 here, looks like it meant to be !*s.

The preceding is terminated by a linefeed at line 1963.


-- 
Cheers,
Cy Schubert <Cy.Schubert at komquats.com> or <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.