svn commit: r302092 - in head/lib/libc: aarch64/sys amd64/sys arm/sys i386/sys mips/sys powerpc/sys powerpc64/sys riscv/sys sparc64/sys sys

[Ivan Klymenko]

On Wed, 22 Jun 2016 21:11:27 +0000 (UTC)
Brooks Davis <brooks at FreeBSD.org> wrote:

> Author: brooks
> Date: Wed Jun 22 21:11:27 2016
> New Revision: 302092
> URL: https://svnweb.freebsd.org/changeset/base/302092
> 
> Log:
>   Replace use of the pipe(2) system call with pipe2(2) with a zero
> flags value.
>   
>   This eliminates the need for machine dependant assembly wrappers for
>   pipe(2).
>   
>   It also make passing an invalid address to pipe(2) return EFAULT
> rather than triggering a segfault.  Document this behavior (which was
> already true for pipe2(2), but undocumented).
>   
>   Reviewed by:	andrew
>   Approved by:	re (gjb)
>   Sponsored by:	DARPA, AFRL
>   Differential Revision:	https://reviews.freebsd.org/D6815
> 
> Added:
>   head/lib/libc/sys/pipe.c   (contents, props changed)
> Deleted:
>   head/lib/libc/aarch64/sys/pipe.S
>   head/lib/libc/amd64/sys/pipe.S
>   head/lib/libc/arm/sys/pipe.S
>   head/lib/libc/i386/sys/pipe.S
>   head/lib/libc/mips/sys/pipe.S
>   head/lib/libc/powerpc/sys/pipe.S
>   head/lib/libc/powerpc64/sys/pipe.S
>   head/lib/libc/riscv/sys/pipe.S
>   head/lib/libc/sparc64/sys/pipe.S
> Modified:
>   head/lib/libc/aarch64/sys/Makefile.inc
>   head/lib/libc/amd64/sys/Makefile.inc
>   head/lib/libc/arm/sys/Makefile.inc
>   head/lib/libc/i386/sys/Makefile.inc
>   head/lib/libc/mips/sys/Makefile.inc
>   head/lib/libc/powerpc/sys/Makefile.inc
>   head/lib/libc/powerpc64/sys/Makefile.inc
>   head/lib/libc/riscv/sys/Makefile.inc
>   head/lib/libc/sparc64/sys/Makefile.inc
>   head/lib/libc/sys/Makefile.inc
>   head/lib/libc/sys/pipe.2
> 

...
/usr/local/libexec/ccache/world/cc -target x86_64-unknown-freebsd11.0
--sysroot=/media/da0s1/obj/usr/src/tmp
-B/media/da0s1/obj/usr/src/tmp/usr/bin -fpic -DPIC  -O2 -pipe -mmmx
-msse -msse2 -msse3 -mssse3 -msse4 -msse4.1 -msse4.2 -mavx -maes
-mpclmul -march=native  -I/usr/src/lib/libc/include
-I/usr/src/lib/libc/../../include -I/usr/src/lib/libc/amd64 -DNLS
-D__DBINTERFACE_PRIVATE -I/usr/src/lib/libc/../../contrib/gdtoa
-I/usr/src/lib/libc/../../contrib/libc-vis -DINET6
-I/media/da0s1/obj/usr/src/lib/libc -I/usr/src/lib/libc/resolv
-D_ACL_PRIVATE -DPOSIX_MISTAKE -I/usr/src/lib/libc/../libmd
-I/usr/src/lib/libc/../../contrib/jemalloc/include -DMALLOC_PRODUCTION
-I/usr/src/lib/libc/../../contrib/tzcode/stdtime
-I/usr/src/lib/libc/stdtime -I/usr/src/lib/libc/locale -DBROKEN_DES
-DPORTMAP -DDES_BUILTIN -I/usr/src/lib/libc/rpc -DYP -DNS_CACHING
-DSYMBOL_VERSIONING -DNDEBUG -MD  -MF.depend.gettimeofday.So
-MTgettimeofday.So -std=gnu99 -fstack-protector-strong -Wsystem-headers
-Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign
-Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable
-Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality
-Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef
-Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter  -Ofast
-fvectorize -fslp-vectorize -fblocks -fcolor-diagnostics
-Qunused-arguments  -I/usr/src/lib/libutil -I/usr/src/lib/msun/amd64
-I/usr/src/lib/msun/x86 -I/usr/src/lib/msun/src
-c /usr/src/lib/libc/sys/gettimeofday.c -o gettimeofday.So --- pipe.So
--- /usr/local/libexec/ccache/world/cc -target
x86_64-unknown-freebsd11.0 --sysroot=/media/da0s1/obj/usr/src/tmp
-B/media/da0s1/obj/usr/src/tmp/usr/bin -fpic -DPIC -O2 -pipe -mmmx
-msse -msse2 -msse3 -mssse3 -msse4 -msse4.1 -msse4.2 -mavx -maes
-mpclmul -march=native  -I/usr/src/lib/libc/include
-I/usr/src/lib/libc/../../include -I/usr/src/lib/libc/amd64 -DNLS
-D__DBINTERFACE_PRIVATE -I/usr/src/lib/libc/../../contrib/gdtoa
-I/usr/src/lib/libc/../../contrib/libc-vis -DINET6
-I/media/da0s1/obj/usr/src/lib/libc -I/usr/src/lib/libc/resolv
-D_ACL_PRIVATE -DPOSIX_MISTAKE -I/usr/src/lib/libc/../libmd
-I/usr/src/lib/libc/../../contrib/jemalloc/include -DMALLOC_PRODUCTION
-I/usr/src/lib/libc/../../contrib/tzcode/stdtime
-I/usr/src/lib/libc/stdtime -I/usr/src/lib/libc/locale -DBROKEN_DES
-DPORTMAP -DDES_BUILTIN -I/usr/src/lib/libc/rpc -DYP -DNS_CACHING
-DSYMBOL_VERSIONING -DNDEBUG -MD  -MF.depend.pipe.So -MTpipe.So
-std=gnu99 -fstack-protector-strong -Wsystem-headers -Wall
-Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -Wno-empty-body
-Wno-string-plus-int -Wno-unused-const-variable
-Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality
-Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef
-Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter  -Ofast
-fvectorize -fslp-vectorize -fblocks -fcolor-diagnostics
-Qunused-arguments  -I/usr/src/lib/libutil -I/usr/src/lib/msun/amd64
-I/usr/src/lib/msun/x86 -I/usr/src/lib/msun/src
-c /usr/src/lib/libc/amd64/sys/pipe.S -o pipe.So cc: error: no such
file or directory: '/usr/src/lib/libc/amd64/sys/pipe.S' cc: error: no
input files *** [pipe.So] Error code 1

make[4]: stopped in /usr/src/lib/libc
1 error

make[4]: stopped in /usr/src/lib/libc
*** [lib/libc__L] Error code 2

make[3]: stopped in /usr/src
1 error

make[3]: stopped in /usr/src
*** [libraries] Error code 2

make[2]: stopped in /usr/src
1 error

make[2]: stopped in /usr/src
*** [_libraries] Error code 2

make[1]: stopped in /usr/src
1 error

make[1]: stopped in /usr/src
*** [buildworld] Error code 2

make: stopped in /usr/src
1 error

make: stopped in /usr/src
root at nonamehost:/usr/src #