svn commit: r301713 - head/sys/dev/random

Glen Barber gjb at FreeBSD.org
Thu Jun 9 14:10:43 UTC 2016


On Thu, Jun 09, 2016 at 06:25:34AM -0700, Simon J. Gerraty wrote:
> Glen Barber <gjb at FreeBSD.org> wrote:
> > >  
> > > -void read_rate_increment(u_int);
> > > +void	random_harvest_queue(const void *, u_int, u_int,
> > > +	    enum random_entropy_source);
> > > +void	read_rate_increment(u_int);
> > >  
> > >  #define	RANDOM_HARVESTQ_BOOT_ENTROPY_FILE	"/boot/entropy"
> > >  
> > 
> > This breaks sparc64.
> 
> Looks like defined(DEV_RANDOM) is relevant.
> Wrapping the prototype in random_harvestq.h in
> 
> #ifndef DEV_RANDOM
> 
> would avoid this issue.
> But backing out until we check if that fixes the original issue steve
> hit is probably best?
> 

IMHO, backing it out is the best solution for now, since a followup
review will be required by so@ for a subsequent commit here.

Glen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20160609/78195ad9/attachment.sig>


More information about the svn-src-head mailing list