svn commit: r303586 - head/bin/sh

Alexey Dokuchaev danfe at FreeBSD.org
Sun Jul 31 13:43:16 UTC 2016


On Sun, Jul 31, 2016 at 01:11:34PM +0000, Jilles Tjoelker wrote:
> New Revision: 303586
> URL: https://svnweb.freebsd.org/changeset/base/303586
> 
> Log:
>   sh: Fix a clang warning.
>   
>   Submitted by:	bdrewery
> 
> Modified:
>   head/bin/sh/expand.c
> 
> Modified: head/bin/sh/expand.c
> ==============================================================================
> --- head/bin/sh/expand.c	Sun Jul 31 12:59:10 2016	(r303585)
> +++ head/bin/sh/expand.c	Sun Jul 31 13:11:34 2016	(r303586)
> @@ -473,7 +473,8 @@ expbackq(union node *cmd, int quoted, in
>  		if (--in.nleft < 0) {
>  			if (in.fd < 0)
>  				break;
> -			while ((i = read(in.fd, buf, sizeof buf)) < 0 && errno == EINTR);
> +			while ((i = read(in.fd, buf, sizeof buf)) < 0 && errno == EINTR)
> +				;

`continue;' would be even better; some tools might barf at stray semicolon.

./danfe


More information about the svn-src-head mailing list