svn commit: r303046 - head/lib/libc/locale

[Pedro Giffuni]

On 07/19/16 16:22, Pedro Giffuni wrote:
> Hi;
>
> On 07/19/16 15:46, Ed Schouten wrote:
>> Hi Pedro,
>>
>> 2016-07-19 22:22 GMT+02:00 Pedro F. Giffuni <pfg at freebsd.org>:
>>> Author: pfg
>>> Date: Tue Jul 19 20:22:13 2016
>>> New Revision: 303046
>>> URL: https://svnweb.freebsd.org/changeset/base/303046
>>>
>>> Log:
>>>   libc: tag the Rune initialization function prototypes visibility as
>>> hidden.
>>
>> How does this interact with symbol versioning/mapping? Wouldn't our C
>> library's symbol map already make these symbols hidden without any
>> explicit annotation?
>>
>
> It shouldn't hurt at all, this is not the first use that we make of the
> visibility attributes in libc. I do notice we tend to put them at the
> end of the prototype, while I followed the Apple notation of setting
> them in front. No idea if that is worthwhile to change.
>
> It is true that these symbols should already be hidden but in the case
> some port is using -fvisibility= compiler flag this will prevent the
> symbols from getting exported by accident.
>

Hmm... actually, you probably can't unhide the regular functions with
-fvisibility. It just doesn't hurt to have the extra insurance, plus
it's generally not wrong to be compatible with Apple ;).

Pedro.