svn commit: r302985 - head/sys/geom/label

Andrey V. Elsukov bu7cher at yandex.ru
Mon Jul 18 19:14:44 UTC 2016


On 18.07.16 17:24, Maxim Sobolev wrote:
> Andrey, are you talking about this:
> 
> ---
> r156299 | pjd | 2006-03-04 11:41:54 -0800 (сб, 04 мар 2006) | 11 lines
> 
> We need to check if file system size is equal to provider's size, because
> sysinstall(8) still bogusly puts first partition at offset 0 instead of 16,
> so glabel/ufs will find file system on slice instead of partition.
> 
> Before sysinstall is fixed, we must keep this code, which means that we
> wont't be able to detect UFS file systems created with 'newfs -s ...'.
> 
> PS. bsdlabel(8) creates partitions properly.
> 
> MFC after:      3 days
> ---
> 
> In which case this particular change has a better chance of working
> since it's not removing this check but making it less strict. Therefore
> it might attach to a wrong provider only if first UFS slice is the only
> one slice on partition (or if the other partition is very small - less
> than 256 blocks in size). In either of those cases I don't think it
> makes much difference if we are attaching to a slice or a partition.

No, I mean r235918, that was reverted after several complains.
UFS label is a special label. It always had the same size that provider.
Now it will attach to first provider that will be tasted. It can be
gmirror, generic glabel, geli, gpart, mbr, whole disk.

https://lists.freebsd.org/pipermail/freebsd-geom/2009-April/003473.html

-- 
WBR, Andrey V. Elsukov

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 563 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20160718/f3abb03a/attachment.sig>


More information about the svn-src-head mailing list