svn commit: r302328 - in head/sys: kern sys

Bruce Evans brde at optusnet.com.au
Tue Jul 5 10:08:50 UTC 2016


On Sun, 3 Jul 2016, Konstantin Belousov wrote:

This is mostly a test reply (replying to src-committers has stopped
working for newer commits).

> Log:
>  Provide helper macros to detect 'non-silent SBDRY' state and to
>  calculate appropriate return value for stops.  Simplify the code by
>  using them.
>
>  Fix typo in sig_suspend_threads().  The thread which sleep must be
>  aborted is td2. (*)
>
>  In issignal(), when handling stopping signal for thread in
>  TD_SBDRY_INTR state, do not stop, this is wrong and fires assert.
>  This is yet another place where execution should be forced out of
>  SBDRY-protected region.  For such case, return -1 from issignal() and
>  translate it to corresponding error code in sleepq_catch_signals().
>  Assert that other consumers of cursig() are not affected by the new
>  return value. (*)
>
>  Micro-optimize, mostly VFS and VOP methods, by avoiding calling the
>  functions when SIGDEFERSTOP_NOP non-change is requested. (**)
>
>  Reported and tested by:	pho (*)
>  Requested by:	bde (**)
>  Sponsored by:	The FreeBSD Foundation
>  MFC after:	2 weeks
>  Approved by:	re (gjb)

Thanks, but this is still very slow (even slower than beore the
micro-optimization).

Bruce


More information about the svn-src-head mailing list