svn commit: r293792 - head/sys/boot/uboot/lib

Ian Lepore ian at FreeBSD.org
Wed Jan 13 00:22:14 UTC 2016


Author: ian
Date: Wed Jan 13 00:22:12 2016
New Revision: 293792
URL: https://svnweb.freebsd.org/changeset/base/293792

Log:
  Go back to using uintptr_t, because code that actually compiles is
  infinitely less buggy than code that is theoretically correct in some
  alternate universe.
  
  The uintfptr_t type is apparently a freebsd invention, and exists only when
  compiling the kernel.  It's a little hard to say for sure, since it doesn't
  seem to be documented anywhere except in email advice to unsuspecting and
  overly-trusting souls, who then get to wear the pointy hat for blindly
  following advice without investigating or testing it first.

Modified:
  head/sys/boot/uboot/lib/copy.c

Modified: head/sys/boot/uboot/lib/copy.c
==============================================================================
--- head/sys/boot/uboot/lib/copy.c	Tue Jan 12 23:48:39 2016	(r293791)
+++ head/sys/boot/uboot/lib/copy.c	Wed Jan 13 00:22:12 2016	(r293792)
@@ -100,7 +100,7 @@ uboot_loadaddr(u_int type, void *data, u
 
 		biggest_block = 0;
 		biggest_size = 0;
-		subldr = rounddown2((uintfptr_t)_start, KERN_ALIGN);
+		subldr = rounddown2((uintptr_t)_start, KERN_ALIGN);
 		eubldr = roundup2((uint64_t)uboot_heap_end, KERN_ALIGN);
 		for (i = 0; i < si->mr_no; i++) {
 			if (si->mr[i].flags != MR_ATTR_DRAM)


More information about the svn-src-head mailing list