svn commit: r295465 - head/usr.sbin/services_mkdb
David Malone
dwmalone at maths.tcd.ie
Thu Feb 11 09:15:36 UTC 2016
On Wed, Feb 10, 2016 at 09:40:45AM +0000, Stefan Esser wrote:
> Author: se
> Date: Wed Feb 10 09:40:45 2016
> New Revision: 295465
> URL: https://svnweb.freebsd.org/changeset/base/295465
>
> Log:
> Remove O_SYNC from the options passed to dbmopen().
>
> The services db is created as a temporary file that is moved over the
> existing file after completion. Thus there is no need to immediately
> flush all created db records to the temporary file.
This was changed to fix a problem with fsync not being called, which
can leave the db files empty after a sudden reboot. O_SYNC is not
the right fix, but I think I've found the real problem and there
is an open phabricator report on this, which fixes the problem in
a better way:
https://reviews.freebsd.org/D5186
Reviews appreciated.
David.
More information about the svn-src-head
mailing list