svn commit: r295362 - head/sys/fs/cd9660

Bruce Evans brde at optusnet.com.au
Sun Feb 7 16:48:07 UTC 2016


On Sun, 7 Feb 2016, Pedro Giffuni wrote:

> On 02/07/16 02:13, Bruce Evans wrote:
>> On Sun, 7 Feb 2016, Pedro F. Giffuni wrote:
>> 
>>> Log:
>>>  cd9660: Drop an unnecessary check for NULL.
>>> 
>>>  This was unnecessary and also confused Coverity.
>>> 
>>>  Confirmed on:    NetBSD
>>>  CID:        978558
>> 
>> This leaves many similar bugs unfixed nearby.  One is a null pointer
>> panic, not just an unnecessary check.
>
> I admittedly oversimplified the commit log here.
>
> Not only the value can't be null, our brelse() also ignores NULL values.
>
> From sys/kern/vfs_bio.c:
> ____
> 	/*
> 	 * Many function erroneously call brelse with a NULL bp under rare
> 	 * error conditions. Simply return when called with a NULL bp.
> 	 */
> 	if (bp == NULL)
> 		return;
> ...
> ____

It has only done that for 11 days.

Bruce


More information about the svn-src-head mailing list