svn commit: r294560 - head/etc/rc.d

[Bryan Drewery]

On 1/22/2016 4:14 AM, Dag-Erling Smørgrav wrote:
> Author: des
> Date: Fri Jan 22 12:14:08 2016
> New Revision: 294560
> URL: https://svnweb.freebsd.org/changeset/base/294560
> 
> Log:
>   Do not generate RSA1 or DSA keys by default.
> 
> Modified:
>   head/etc/rc.d/sshd
> 
> Modified: head/etc/rc.d/sshd
> ==============================================================================
> --- head/etc/rc.d/sshd	Fri Jan 22 12:00:56 2016	(r294559)
> +++ head/etc/rc.d/sshd	Fri Jan 22 12:14:08 2016	(r294560)
> @@ -20,9 +20,9 @@ configtest_cmd="sshd_configtest"
>  pidfile="/var/run/${name}.pid"
>  extra_commands="configtest keygen reload"
>  
> -: ${sshd_rsa1_enable:="yes"}
> +: ${sshd_rsa1_enable:="no"}
>  : ${sshd_rsa_enable:="yes"}
> -: ${sshd_dsa_enable:="yes"}
> +: ${sshd_dsa_enable:="no"}
>  : ${sshd_ecdsa_enable:="yes"}
>  : ${sshd_ed25519_enable:="yes"}
>  
> 

I think perhaps you should also remove these as having default paths in
the .c as well and require they be enabled in the config. Otherwise a
warning is given:

Feb  4 15:25:22 VM sshd[874]: error: Could not load host key:
/etc/ssh/ssh_host_dsa_key

Or always generate them but only load them if enabled in the config.

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20160204/b43619bc/attachment.sig>