svn commit: r310789 - head/lib/libpam/static_libpam

[Ravi Pokala]

Hi Alexander,

I'm a little confused - the original version had to have had a compile-only step to generate the object first, before running the link-only operation against the object. The new code replaces the link-only operation with a compile+link operation. Shouldn't the pre-existing compile-only operation be removed, since the new compile+link operation supersedes it?

Thanks,

Ravi (rpokala@)


-----Original Message-----
> From: <owner-src-committers at freebsd.org> on behalf of Alexander Kabaev <kan at FreeBSD.org>
> Date: 2016-12-29, Thursday at 15:30
> To: <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>
> Subject: svn commit: r310789 - head/lib/libpam/static_libpam
> 
> Author: kan
> Date: Thu Dec 29 21:30:52 2016
> New Revision: 310789
> URL: https://svnweb.freebsd.org/changeset/base/310789
> 
> Log:
>   Use compiler driver to build relocatable object
>   
>   This works better with external toolchains where LD
>   will not necessarily defailt to emulation we want.
>   Compiler driver knows better.
> 
> Modified:
>   head/lib/libpam/static_libpam/Makefile
> 
> Modified: head/lib/libpam/static_libpam/Makefile
> ==============================================================================
> --- head/lib/libpam/static_libpam/Makefile	Thu Dec 29 21:06:31 2016	(r310788)
> +++ head/lib/libpam/static_libpam/Makefile	Thu Dec 29 21:30:52 2016	(r310789)
> @@ -64,6 +64,6 @@ CLEANFILES+=	openpam_static.o \
>  		openpam_static_modules.o
>  
>  openpam_static_modules.o: openpam_static.o ${STATIC_MODULES}
> -	${LD} -o ${.TARGET} -r --whole-archive ${.ALLSRC}
> +	${CC} -nostdlib ${CFLAGS} -o ${.TARGET} -r -Wl,--whole-archive ${.ALLSRC}
>  
>  .include "${.CURDIR}/../libpam/Makefile"