svn commit: r310624 - head/sys/net80211

[Shawn Webb]

On Tue, Dec 27, 2016 at 06:10:28AM +0000, Adrian Chadd wrote:
> Author: adrian
> Date: Tue Dec 27 06:10:28 2016
> New Revision: 310624
> URL: https://svnweb.freebsd.org/changeset/base/310624
> 
> Log:
>   [net80211] turn the default TX key configuration (for WEP) into a vap callback.
>   
>   The ath10k firmware supports hardware WEP offload, and in native wifi mode
>   (or 802.3 ethernet mode, for that matter) the WEP key isn't actually included
>   in the TX payload from net80211.  Instead, a separate firmware command is issued
>   that sets the default TX key to be the specified key.
>   
>   However, net80211 doesn't at all inform the driver layer that this is
>   occuring - it just "expects" to be inserting WEP header information
>   when doing WEP TX, even with hardware encryption.
>   
>   So, to better support the newer world order, turn the default TX key assignment
>   into a VAP method that can be overridden by the driver and ensure its wrapped
>   in a crypto begin/end set.  That way it should be correctly atomic from the
>   point of view of keychanges (as long as the driver does the right thing.)
>   
>   It'd be nice if we passed through to the key_set call a flag that says
>   "also make this the default key" - that's captured here by calling the
>   deftxkey method after the key_set method.  Maybe I can do that later.
>   
>   Note: this is a net80211 ABI change, and will require a kernel+modules
>   recompile.  Happy Holidays, etc.

Hey Adrian,

Thank you very much for your hard work on the wireless stack. Since this
introduces an ABI change, should __FreeBSD_version be bumped?

Thanks,

-- 
Shawn Webb
Cofounder and Security Engineer
HardenedBSD

GPG Key ID:          0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89  3D9E 6A84 658F 5245 6EEE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20161227/332f4e16/attachment.sig>