svn commit: r310425 - in head/sys/dev/mlx4: mlx4_core mlx4_ib

Ed Maste emaste at freebsd.org
Thu Dec 22 20:58:00 UTC 2016


On 22 December 2016 at 14:44, Ed Schouten <ed at nuxi.nl> wrote:
> 2016-12-22 19:26 GMT+01:00 Ed Maste <emaste at freebsd.org>:
>> Log:
>>   mlx: avoid use of __DATE__ to make build reproducible
>
> Out of curiosity, are we planning on adding -Wdate-time or
> -Werror=date-time to our default CFLAGS? If so, awesome!

I hadn't thought of it, but good idea. Maybe something like this for now:

--- a/share/mk/bsd.sys.mk
+++ b/share/mk/bsd.sys.mk
@@ -88,6 +88,9 @@ CWARNFLAGS.clang+=    -Wno-parentheses
 .if defined(NO_WARRAY_BOUNDS)
 CWARNFLAGS.clang+=     -Wno-array-bounds
 .endif # NO_WARRAY_BOUNDS
+.if ${MK_REPRODUCIBLE_BUILD} != no
+CWARNFLAGS.clang+=     -Wdate-time
+.endif # MK_REPRODUCIBLE_BUILD
 .endif # WARNS


More information about the svn-src-head mailing list