svn commit: r310171 - head/sys/sys

Sepherosa Ziehau sepherosa at gmail.com
Tue Dec 20 02:14:48 UTC 2016


On Tue, Dec 20, 2016 at 4:37 AM, Ravi Pokala <rpokala at mac.com> wrote:
> -----Original Message-----
>> From: <owner-src-committers at freebsd.org> on behalf of Ian Lepore <ian at freebsd.org>
>> Date: 2016-12-19, Monday at 11:20
>> To: Warner Losh <imp at bsdimp.com>, Ravi Pokala <rpokala at mac.com>
>> Cc: Sepherosa Ziehau <sepherosa at gmail.com>, Dimitry Andric <dim at freebsd.org>, src-committers <src-committers at freebsd.org>, "svn-src-all at freebsd.org" <svn-src-all at freebsd.org>, "svn-src-head at freebsd.org" <svn-src-head at freebsd.org>
>> Subject: Re: svn commit: r310171 - head/sys/sys
>>
>> On Mon, 2016-12-19 at 11:58 -0700, Warner Losh wrote:
>>>
>>> ...
>>>
>>> Are there other precedence for avoiding the SCN macros in the tree as
>>> well, or is this new art?
>>>
>>> Warner
>>
>> There was another commit recently the fixed the same kind of scanf
>> error by making the variable fit the scanf type (changing uint64_t to
>> an explicit long long unsigned, iirc).  I don't know if that alone
>> counts as a precedent, but IMO it's a more palatible fix than the
>> SCN/PRI ugliness.
>
> With all apologies to Churchill, SCN/PRI are the worst way to address this in a machine-independent way, except for all the other ways that have been tried from time to time. :-P
>

If no objection comes, I'd commit the posted patch as it is tomorrow in my time.

Thanks,
sephe

-- 
Tomorrow Will Never Die


More information about the svn-src-head mailing list