svn commit: r310171 - head/sys/sys

Dimitry Andric dim at FreeBSD.org
Mon Dec 19 19:02:54 UTC 2016


On 19 Dec 2016, at 19:58, Warner Losh <imp at bsdimp.com> wrote:
> 
> On Mon, Dec 19, 2016 at 1:39 AM, Ravi Pokala <rpokala at mac.com> wrote:
>> -----Original Message-----
>>> From: <owner-src-committers at freebsd.org> on behalf of Sepherosa Ziehau <sepherosa at gmail.com>
>>> Date: 2016-12-18, Sunday at 23:02
>>> To: Dimitry Andric <dim at freebsd.org>
>>> Cc: <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>
>>> Subject: Re: svn commit: r310171 - head/sys/sys
>>> 
>>> The following patch unbreaks the LINT builds on amd64 for me after this commit:
>>> https://people.freebsd.org/~sephe/geom_sscanf.diff
>> 
>> Wouldn't it be better to use the SCN macros?
> 
> Are there other precedence for avoiding the SCN macros in the tree as
> well, or is this new art?

I personally don't have anything against using the PRI or SCN macros,
but traditionally there has been some backlash against it, if I recall
correctly.  It also requires including either <machine/_inttypes.h> or
<inttypes.h>, depending on circumstance or preference.

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20161219/c902b1b6/attachment.sig>


More information about the svn-src-head mailing list