svn commit: r310242 - head/sys/dev/usb

Hans Petter Selasky hps at selasky.org
Mon Dec 19 17:37:50 UTC 2016


On 12/19/16 17:13, John Baldwin wrote:
> On Monday, December 19, 2016 09:28:13 AM Hans Petter Selasky wrote:
>> Author: hselasky
>> Date: Mon Dec 19 09:28:12 2016
>> New Revision: 310242
>> URL: https://svnweb.freebsd.org/changeset/base/310242
>>
>> Log:
>>   Defer USB enumeration until the SI_SUB_KICK_SCHEDULER is executed to avoid
>>   boot panics in conjunction with the recently added EARLY_AP_STARTUP feature.
>>   The panics happen due to using kernel facilities like callouts too early.
>>
>>   Tested by:	jhb @
>>   MFC after:	1 week
>
> As mentioned in the thread, the patches to usb_hub.c weren't needed and the block
> in usb_process.c can just be removed unconditionally since it should never execute
> in the non-EARLY_AP_STARTUP case.
>

Hi John,

The checks in usb_process.c are needed in case attaching a USB 
controller fails for some unknown reason. Then there is a problem that 
thread0 cannot wait/sleep for the process to exit, so that it doesn't 
access freed memory. Did I miss anything?

--HPS


More information about the svn-src-head mailing list