svn commit: r310000 - head/sys/dev/gpio

Luiz Otavio O Souza loos at FreeBSD.org
Tue Dec 13 03:36:42 UTC 2016


Author: loos
Date: Tue Dec 13 03:36:41 2016
New Revision: 310000
URL: https://svnweb.freebsd.org/changeset/base/310000

Log:
  Remove a too strict test and instead, just filter the passed flags with the
  supported capabilities.
  
  Spotted by:	yamori813 at yahoo.co.jp (Hiroki Mori)
  MFC after:	2 weeks

Modified:
  head/sys/dev/gpio/gpiobus.c

Modified: head/sys/dev/gpio/gpiobus.c
==============================================================================
--- head/sys/dev/gpio/gpiobus.c	Tue Dec 13 03:26:12 2016	(r309999)
+++ head/sys/dev/gpio/gpiobus.c	Tue Dec 13 03:36:41 2016	(r310000)
@@ -120,9 +120,9 @@ int
 gpio_check_flags(uint32_t caps, uint32_t flags)
 {
 
-	/* Check for unwanted flags. */
-	if ((flags & caps) == 0 || (flags & caps) != flags)
-		return (EINVAL);
+	/* Filter unwanted flags. */
+	flags &= caps;
+
 	/* Cannot mix input/output together. */
 	if (flags & GPIO_PIN_INPUT && flags & GPIO_PIN_OUTPUT)
 		return (EINVAL);


More information about the svn-src-head mailing list