svn commit: r304142 - head/usr.sbin/bsdinstall/partedit

[Warner Losh]

On Wed, Aug 17, 2016 at 9:26 AM, Nathan Whitehorn
<nwhitehorn at freebsd.org> wrote:
> Not true at all. All modern disks report their physical sector size, as
> distinct from the logical one, in their ATA IDENTIFY data and ata_da.c uses
> that.

You are correct that there are two fields in the ATA IDENTIFY. However,
you are incorrect in thinking that all modern disks report their actual
physical sector size instead of a 'compatibility' number. We have dozens
of quirks and are adding them at the rate of a couple a month to make the
current imperfect magic happen.

> There is also a small quirks table for some older spinning disks and a
> few SSDs that lie and mostly hasn't needed additions in quite some time.
> camcontrol identify correctly reports 4096 for the physical sector size on 5
> different random AF-512e disks I just checked (some of those are also,
> redundantly, in the quirks table). Since this seems to have become the
> standard, I can't imagine that the quirks table would need to grow much in
> the future for this issue.

Any yet the table continues to grow. As someone who evaluates disks for a large
streaming media company, you cannot begin to imagine the number of things
that vendors get wrong... Life would be so much easier if you could actually
trust vendors to report things correctly in their ATA IDENTIFY command.
SCSI is better, but still not perfect.

You should really listen to people that have been on the front line here.
CAM does a decent job of getting things right. It isn't perfect and can never
be perfect. Expecting it to magically change to be perfect is unreasonable
and will literally never happen.

Warner