svn commit: r303934 - head/usr.bin/truss

Bryan Drewery bdrewery at FreeBSD.org
Wed Aug 10 18:44:51 UTC 2016


On 8/10/16 11:41 AM, Konstantin Belousov wrote:
> On Wed, Aug 10, 2016 at 06:19:17PM +0000, Bryan Drewery wrote:
>> Author: bdrewery
>> Date: Wed Aug 10 18:19:17 2016
>> New Revision: 303934
>> URL: https://svnweb.freebsd.org/changeset/base/303934
>>
>> Log:
>>   Support rmdir(2).
>>   
>>   MFC after:	3 days
>>   Sponsored by:	EMC / Isilon Storage Division
>>
>> Modified:
>>   head/usr.bin/truss/syscalls.c
>>
>> Modified: head/usr.bin/truss/syscalls.c
>> ==============================================================================
>> --- head/usr.bin/truss/syscalls.c	Wed Aug 10 18:19:14 2016	(r303933)
>> +++ head/usr.bin/truss/syscalls.c	Wed Aug 10 18:19:17 2016	(r303934)
>> @@ -279,6 +279,8 @@ static struct syscall decoded_syscalls[]
>>  	  .args = { { Name, 0 }, { Name, 1 } } },
>>  	{ .name = "renameat", .ret_type = 1, .nargs = 4,
>>  	  .args = { { Atfd, 0 }, { Name, 1 }, { Atfd, 2 }, { Name, 3 } } },
>> +	{ .name = "rmdir", .ret_type = 1, .nargs = 2,
>> +	  .args = { { Name, 0 }, { Octal, 1 } } },
> I do not quite follow this.  The table format is that nargs is the number
> of arguments to the syscall, and args describe each syscall' argument,
> are my assumptions right ?
> 
> If yes, what is the second rmdir(2) argument for ?

You're right, it's a bug.  I had copied the wrong syscall and missed this.

Fixing it, thanks.

> 
>>  	{ .name = "rfork", .ret_type = 1, .nargs = 1,
>>  	  .args = { { Rforkflags, 0 } } },
>>  	{ .name = "select", .ret_type = 1, .nargs = 5,


-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20160810/aeaba821/attachment.sig>


More information about the svn-src-head mailing list