svn commit: r298758 - head/sbin/camcontrol

Garrett Cooper ngie at FreeBSD.org
Thu Apr 28 21:17:24 UTC 2016


Author: ngie
Date: Thu Apr 28 21:17:23 2016
New Revision: 298758
URL: https://svnweb.freebsd.org/changeset/base/298758

Log:
  Remove logically impossible test in scsidoinquiry(..)
  
  It was already done 4 lines prior and the value of error didn't change
  
  MFC after: 3 days
  Reported by: Coverity
  CID: 1011236
  Sponsored by: EMC / Isilon Storage Division

Modified:
  head/sbin/camcontrol/camcontrol.c

Modified: head/sbin/camcontrol/camcontrol.c
==============================================================================
--- head/sbin/camcontrol/camcontrol.c	Thu Apr 28 20:30:49 2016	(r298757)
+++ head/sbin/camcontrol/camcontrol.c	Thu Apr 28 21:17:23 2016	(r298758)
@@ -814,9 +814,6 @@ scsidoinquiry(struct cam_device *device,
 	if (arglist & CAM_ARG_GET_SERIAL)
 		scsiserial(device, retry_count, timeout);
 
-	if (error != 0)
-		return(error);
-
 	if (arglist & CAM_ARG_GET_XFERRATE)
 		error = camxferrate(device);
 


More information about the svn-src-head mailing list