svn commit: r298462 - head/contrib/bsnmp/snmp_mibII

Ngie Cooper (yaneurabeya) yaneurabeya at gmail.com
Fri Apr 22 07:55:03 UTC 2016


> On Apr 22, 2016, at 00:51, Garrett Cooper <ngie at FreeBSD.org> wrote:
> 
> Author: ngie
> Date: Fri Apr 22 07:51:38 2016
> New Revision: 298462
> URL: https://svnweb.freebsd.org/changeset/base/298462
> 
> Log:
>  Return `ret` in op_ifentry(..) to mute a -Wunused-but-set-variable warning
> 
>  This will also now detect error conditions with
>  value->var.subs[sub - 1] == LEAF_ifPhysAddress where `string_get(..)`
>  could fail if iifp->physaddr and/or iifp->physaddrlen were deemed
>  invalid.
> 
>  MFC after: 2 weeks
>  CID: 1006551
>  Reported by: Coverity, gcc
>  Sponsored by: EMC / Isilon Storage Division

I pulled up the wrong CID. Coverity didn’t actually complain about this — just gcc.
Thanks,
-Ngie


More information about the svn-src-head mailing list