svn commit: r298247 - head/sbin/fdisk_pc98

Conrad Meyer cem at FreeBSD.org
Wed Apr 20 14:41:44 UTC 2016


On Wed, Apr 20, 2016 at 7:33 AM, Pedro Giffuni <pfg at freebsd.org> wrote:
> One of the things I dislike is that most of the macros are in
> lowercase. Lowercase would make sense if these were inline functions
> but inline functions have disadvantages for these use cases.
> OTOH, if they were uppercase, they would not be very easy on the eyes,
> which is the current advantage.


You bring up a good point.  Obviously nitems() can't be an inline
function, but roundup2() and friends could.  Is there any reason not
to change them over to inline functions?

Best,
Conrad


More information about the svn-src-head mailing list