svn commit: r298268 - head/sys/dev/spibus

Ruslan Bukin ruslan.bukin at cl.cam.ac.uk
Tue Apr 19 15:41:38 UTC 2016


On Tue, Apr 19, 2016 at 08:41:39AM -0600, Ian Lepore wrote:
> On Tue, 2016-04-19 at 14:18 +0000, Ruslan Bukin wrote:
> > Author: br
> > Date: Tue Apr 19 14:18:12 2016
> > New Revision: 298268
> > URL: https://svnweb.freebsd.org/changeset/base/298268
> > 
> > Log:
> >   Add optional chip_select/deselect methods. This is required
> >   when we want to keep CS asserted for multiple transfers.
> > 
> 
> This is missing a now-required mechanism to arbitrate ownership of the
> bus.  If a leaf driver can take over the bus for longer than a single
> transfer, then it needs the same kind of logic as the iicbus uses
> (well, conceptually the same, it doesn't need the same horrible
> implementation).
> 
> I also don't see any default implementation of the new methods, or a
> commit that adds the new functionality to all existing SPI controller
> drivers.
> 

Thanks, Ian.
I just realized we don't require to hold CS for multiple transfers
in our hardware. So I reverted this.

Ruslan



More information about the svn-src-head mailing list