svn commit: r287185 - head/share/mk

Warner Losh imp at bsdimp.com
Wed Sep 23 16:37:13 UTC 2015


I've been making a pass through the tree and found that

FOO.${MK_BAR}+= a b c

vs

.if ${MK_BAR} != "no"
FOO+= a b c
.endif

simpler to understand. This commit is one small slice of that which I could
commit. These files have a high enough churn rate that I'm not always able
to keep up enough to push my changes. So this was part of what I could do
today to start to reduce my patch-set.

This was discussed on arch at freebsd.org a while ago.

Warner

On Tue, Sep 22, 2015 at 9:32 PM, Bryan Drewery <bdrewery at freebsd.org> wrote:

> On 8/26/15 6:52 PM, Warner Losh wrote:
> > Author: imp
> > Date: Thu Aug 27 01:52:45 2015
> > New Revision: 287185
> > URL: https://svnweb.freebsd.org/changeset/base/287185
> >
> > Log:
> >   For each FOO in FILESLISTS, append the value of FOO.yes, sort, and
> >   remove duplicates.
> >
> > Modified:
> >   head/share/mk/bsd.files.mk
> >
> > Modified: head/share/mk/bsd.files.mk
> >
> ==============================================================================
> > --- head/share/mk/bsd.files.mk        Thu Aug 27 01:02:01 2015
> (r287184)
> > +++ head/share/mk/bsd.files.mk        Thu Aug 27 01:52:45 2015
> (r287185)
> > @@ -10,6 +10,9 @@ __<bsd.files.mk>__:
> >  FILESGROUPS?=        FILES
> >
> >  .for group in ${FILESGROUPS}
> > +# Add in foo.yes and remove duplicates from all the groups
> > +${${group}}:= ${${group}} ${${group}.yes}
> > +${${group}}:= ${${group}:O:u}
> >  buildfiles: ${${group}}
> >  .endfor
> >
> >
>
> What is this for?
>
> --
> Regards,
> Bryan Drewery
>


More information about the svn-src-head mailing list