svn commit: r288026 - head/lib/libc/stdlib

Jilles Tjoelker jilles at stack.nl
Sun Sep 20 20:37:51 UTC 2015


On Sun, Sep 20, 2015 at 08:15:45PM +0000, Craig Rodrigues wrote:
> Author: rodrigc
> Date: Sun Sep 20 20:15:44 2015
> New Revision: 288026
> URL: https://svnweb.freebsd.org/changeset/base/288026

> Log:
>   Remove names from prototypes

> Modified:
>   head/lib/libc/stdlib/atexit.c
>   head/lib/libc/stdlib/heapsort.c
>   head/lib/libc/stdlib/merge.c
> [snip patch]

Although style(9) does not mention userland implementation files
explicitly, I think it is OK to use parameter names for them, for the
extra information. Since these are not header files visible to
applications, protected names (_foo) are not necessary.

I wouldn't commit a change that only either adds or removes parameter
names in prototypes myself, except to a header file visible to
applications (to fix namespace pollution).

-- 
Jilles Tjoelker


More information about the svn-src-head mailing list