svn commit: r287356 - head/sys/dev/mmc/host

Andrew Turner andrew at FreeBSD.org
Tue Sep 1 10:47:43 UTC 2015


Author: andrew
Date: Tue Sep  1 10:47:42 2015
New Revision: 287356
URL: https://svnweb.freebsd.org/changeset/base/287356

Log:
  Remove an variable we only ever write to, and stop assigning 0 to values
  in the softc as it's the default value. The latter helps with subclassing
  this driver.
  
  Sponsored by:	ABT Systems Ltd

Modified:
  head/sys/dev/mmc/host/dwmmc.c

Modified: head/sys/dev/mmc/host/dwmmc.c
==============================================================================
--- head/sys/dev/mmc/host/dwmmc.c	Tue Sep  1 09:33:24 2015	(r287355)
+++ head/sys/dev/mmc/host/dwmmc.c	Tue Sep  1 10:47:42 2015	(r287356)
@@ -538,7 +538,6 @@ static int
 dwmmc_attach(device_t dev)
 {
 	struct dwmmc_softc *sc;
-	device_t child;
 	int error;
 	int slot;
 
@@ -574,8 +573,6 @@ dwmmc_attach(device_t dev)
 	device_printf(dev, "Hardware version ID is %04x\n",
 		READ4(sc, SDMMC_VERID) & 0xffff);
 
-	sc->use_pio = 0;
-	sc->pwren_inverted = 0;
 	sc->desc_count = DESC_MAX;
 
 	if ((sc->hwtype & HWTYPE_MASK) == HWTYPE_ROCKCHIP) {
@@ -651,7 +648,7 @@ dwmmc_attach(device_t dev)
 	sc->host.host_ocr = MMC_OCR_320_330 | MMC_OCR_330_340;
 	sc->host.caps = MMC_CAP_4_BIT_DATA;
 
-	child = device_add_child(dev, "mmc", 0);
+	device_add_child(dev, "mmc", 0);
 	return (bus_generic_attach(dev));
 }
 


More information about the svn-src-head mailing list