svn commit: r290110 - in head: include lib/libc/stdio

[Conrad Meyer]

On Wed, 28 Oct 2015 08:52:15 -0700
Xin Li <delphij at delphij.net> wrote:
> On 10/28/15 07:40, Andrey A. Chernov wrote:

> >   Add _flags2 per jhb@ suggestion since no room left in
> > _flags. Rewrite O_APPEND flag checking using new __S2OAP
> > flag.
> 
> Is this ABI-safe?  (I was somewhat surprised that struct
> FILE is not opaque, which seems to be unavoidable because
> some methods are traditionally macros that have direct
> access to the members; the addition is done in the end of
> the structure so it looks like the change is safe).


It breaks anything that depends on the size of __sFILE
(IMO dead code walking).  Otherwise it should be ABI
compatible, since the flags2 member is only added at the end.

JHB has a patch floating around to remove all the FILE macros
and re-private the contents of the FILE struct.  As Bryan
said already, Perl reaches in directly for the fd number and
needs to be fixed before that can land.

Best,
Conrad