svn commit: r289863 - head/lib/libc/stdio

[Andrey Chernov]

On 26.10.2015 20:27, John Baldwin wrote:
> On Saturday, October 24, 2015 02:23:15 AM Andrey A. Chernov wrote:
>> Author: ache
>> Date: Sat Oct 24 02:23:15 2015
>> New Revision: 289863
>> URL: https://svnweb.freebsd.org/changeset/base/289863
>>
>> Log:
>>   Since no room left in the _flags, reuse __SALC for O_APPEND.
>>   It helps to remove _fcntl() call from _ftello() and optimize seek position
>>   calculation in _swrite().
> 
> You could just add a _flags2 to FILE if that would be cleaner.  It should even
> be MFC'able without being an ABI change since stdio always allocates FILE
> objects internally and we only export pointers to them.  Programs do not
> allocate them statically.
> 

Thanx, I understand it from your bugzilla answer, but I have a doubt.
What if some 3rd party port will use static FILE f; and then &f? Some of
ports may deal with FILE internals and I don't know which ones. I prefer
rather to not break something there and currently I need only one flag
and __SALC is not conflicting since used only with _file = -1 and
__SSTR. If you or somebody else will need another flag and be brave
enough to add _flags2, this patch can be easily converted.

-- 
http://ache.vniz.net/