svn commit: r289350 - head/sys/netinet

[Bjoern A. Zeeb]

> On 16 Oct 2015, at 12:31 , Gleb Smirnoff <glebius at freebsd.org> wrote:
> 
> On Thu, Oct 15, 2015 at 01:44:32AM +0000, Bjoern A. Zeeb wrote:
> B> Author: bz
> B> Date: Thu Oct 15 01:44:32 2015
> B> New Revision: 289350
> B> URL: https://svnweb.freebsd.org/changeset/base/289350
> B> 
> B> Log:
> B>   Hopefully also unbreak VIMAGE kernels replacing the &V_... with
> B>   &VNET_NAME(...).
> B>   Everything else is just a whitespace wrapping change.
> B> 
> B> Modified:
> B>   head/sys/netinet/tcp_pcap.c
> B> 
> B> Modified: head/sys/netinet/tcp_pcap.c
> B> ==============================================================================
> B> --- head/sys/netinet/tcp_pcap.c	Thu Oct 15 01:09:14 2015	(r289349)
> B> +++ head/sys/netinet/tcp_pcap.c	Thu Oct 15 01:44:32 2015	(r289350)
> B> @@ -70,9 +70,9 @@ SYSCTL_INT(_net_inet_tcp, OID_AUTO, tcp_
> B>  
> B>  VNET_DEFINE(int, tcp_pcap_packets) = 0;
> B>  #define V_tcp_pcap_packets	VNET(tcp_pcap_packets)
> B> -SYSCTL_INT(_net_inet_tcp, OID_AUTO, tcp_pcap_packets, CTLFLAG_RW,
> B> -	&V_tcp_pcap_packets, 0, "Default number of packets saved per direction "
> B> -	"per TCPCB");
> B> +SYSCTL_INT(_net_inet_tcp, OID_AUTO, tcp_pcap_packets,
> B> +	CTLFLAG_RW, &VNET_NAME(tcp_pcap_packets), 0,
> B> +	"Default number of packets saved per direction per TCPCB");
> 
> It also lacks CTLFLAG_VNET flag. Will panic on write now.

Yeah, I had followed up on that in PB (not checked what happened since yet).
The real question is whether this should be allowed to be changed from within a VNET as that opens the machine up to a local DoS if you ask me.

The above was just to make it compile again and make GENERIC work.

Bjoern