svn commit: r289728 - head

[Julian Elischer]

On 10/22/15 9:45 AM, Alexander Kabaev wrote:
> On Thu, 22 Oct 2015 01:32:11 +0000 (UTC)
> Ed Maste <emaste at FreeBSD.org> wrote:
>
>> Author: emaste
>> Date: Thu Oct 22 01:32:11 2015
>> New Revision: 289728
>> URL: https://svnweb.freebsd.org/changeset/base/289728
>>
>> Log:
>>    Warn that NOCLEAN is deprecated - use NO_CLEAN instead
>>    
>>    NO_CLEAN has been the correct spelling for over a decade.
>>
>> Modified:
>>    head/Makefile.inc1
>>
>> Modified: head/Makefile.inc1
>> ==============================================================================
>> --- head/Makefile.inc1	Thu Oct 22 01:04:31 2015
>> (r289727) +++ head/Makefile.inc1	Thu Oct 22 01:32:11
>> 2015	(r289728) @@ -128,6 +128,7 @@ SUBDIR+=etc
>>   .endif	# !empty(SUBDIR_OVERRIDE)
>>   
>>   .if defined(NOCLEAN)
>> +.warning NOCLEAN option is deprecated. Use NO_CLEAN instead.
>>   NO_CLEAN=	${NOCLEAN}
>>   .endif
>>   .if defined(NO_CLEANDIR)
>
> For some definition of 'correct'. It definitely is not for those who
> have -DNOCLEAN wired into their finger memory and above mentioned
> decade did not help with that any.
>
> I think some of the common spellings were left as is in great NO_<foo>
> revolution for a reason and I see no reason why the sudden itch to
> change that.

I can never remember what the right way for WITHXXX WITH_XXX DO_XXX   
NO_XXX  NOXXX  etc. is..  I go look for examples every time.