svn commit: r289615 - head/sys/dev/ntb/if_ntb

Conrad E. Meyer cem at FreeBSD.org
Tue Oct 20 01:54:35 UTC 2015


Author: cem
Date: Tue Oct 20 01:54:34 2015
New Revision: 289615
URL: https://svnweb.freebsd.org/changeset/base/289615

Log:
  if_ntb: Fix typo in qp_link_work to match Linux
  
  Throw away the result of the peer SPAD read.  The peer will write our
  local SPAD and we need to keep the locally read SPAD value to check if
  the remote side is up.
  
  Sponsored by:	EMC / Isilon Storage Division

Modified:
  head/sys/dev/ntb/if_ntb/if_ntb.c

Modified: head/sys/dev/ntb/if_ntb/if_ntb.c
==============================================================================
--- head/sys/dev/ntb/if_ntb/if_ntb.c	Tue Oct 20 01:54:25 2015	(r289614)
+++ head/sys/dev/ntb/if_ntb/if_ntb.c	Tue Oct 20 01:54:34 2015	(r289615)
@@ -1381,14 +1381,14 @@ ntb_qp_link_work(void *arg)
 	struct ntb_transport_qp *qp = arg;
 	struct ntb_softc *ntb = qp->ntb;
 	struct ntb_transport_ctx *nt = qp->transport;
-	int val;
+	uint32_t val, dummy;
 
 	ntb_spad_read(ntb, IF_NTB_QP_LINKS, &val);
 
 	ntb_peer_spad_write(ntb, IF_NTB_QP_LINKS, val | (1ull << qp->qp_num));
 
 	/* query remote spad for qp ready bits */
-	ntb_peer_spad_read(ntb, IF_NTB_QP_LINKS, &val);
+	ntb_peer_spad_read(ntb, IF_NTB_QP_LINKS, &dummy);
 
 	/* See if the remote side is up */
 	if ((val & (1ull << qp->qp_num)) != 0) {


More information about the svn-src-head mailing list