svn commit: r289276 - in head/sys: conf kern netinet sys

Jonathan Looney jlooney at juniper.net
Wed Oct 14 23:23:19 UTC 2015


On 10/14/15, 7:38 AM, "Gleb Smirnoff" <glebius at FreeBSD.org> wrote:
>What if we write it down this way (thanks C11):
>
>struct tcpcb {
>	...
>	union {
>#ifdef TCPPCAP
>		struct {
>			struct mbufq t_inpkts;
>			struct mbufq t_outpkts;
>		};
>#endif
>		uint64_t _pad[6];
>	}
>};
>
>So, compiler cares about pointer size, not us. And more readable, IMHO.

Hi Gleb,

Thanks! I agree. I'll include this in a cleanup patch that addresses the
comments received after the commit.

Jonathan



More information about the svn-src-head mailing list