svn commit: r289087 - in head: etc etc/dma libexec libexec/dma libexec/dma-mbox-create libexec/dma/dma libexec/dma/dma-mbox-create share/examples share/examples/dma

[Baptiste Daroussin]

On Mon, Oct 12, 2015 at 02:24:52PM +0200, Baptiste Daroussin wrote:
> On Mon, Oct 12, 2015 at 02:02:39PM +0200, Baptiste Daroussin wrote:
> > On Mon, Oct 12, 2015 at 03:28:58AM -0700, Peter Wemm wrote:
> > > On Saturday, October 10, 2015 04:44:23 PM Baptiste Daroussin wrote:
> > > > On Fri, Oct 09, 2015 at 08:15:57PM -0700, Adrian Chadd wrote:
> > > > > I think this broke being able to do installworld as non-root
> > > > > 
> > > > > 21:03 <@adrian> ===> libexec/dma/dmagent (installconfig)
> > > > > 21:03 <@adrian> install:
> > > > > /home/adrian/work/freebsd/head-embedded/src/../root/mips_ap/etc/dma/dma.co
> > > > > nf: chown/chgrp: Operation not permitted
> > > > > 21:03 <@adrian> *** Error code 71
> > > > 
> > > > Fixed in r289115
> > > > 
> > > > Bapt
> > > 
> > > You've broken etcupdate with this, and also the freebsd cluster.
> > > 
> > > # etcupdate status
> > > Warnings:
> > >   Non-empty directory remains: /etc/dma
> > > 
> > > You also made it delete ppp.conf:
> > >   D /etc/ppp/ppp.conf
> > >   D /etc/ppp
> > > 
> > > Deleting people's config files is not good.
> > 
> > Hu, make installconfig is hooked to make distribution, etcupdate is calling make
> > distribution to retrive the list of configurations files so it should get the
> > config for ppp.
> > 
> > Let me look into the etcupdate to see what is wrong with it.
> > 
> > Best regards,
> > Bapt
> 
> 
> 
> After checking I can confirm that etcupdate properly get the config:
> 
> etcupdate build something.tar
> tar tvf something.tar  | grep ppp.conf
> -rw-------  0 root   wheel    1144 Oct 12 14:23 ./etc/ppp/ppp.conf
> 
> 
> Am I missing something?

I compared the tarball from before and after my change and there is no
differences.

I Compared: r289000 and r289183

Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20151012/b599a6f0/attachment.bin>