svn commit: r288907 - head/bin/ls/tests

[NGie Cooper]

> On Oct 6, 2015, at 11:26, John Baldwin <jhb at freebsd.org> wrote:
> 
> On Tuesday, October 06, 2015 01:00:12 AM Garrett Cooper wrote:
>> Author: ngie
>> Date: Tue Oct  6 01:00:12 2015
>> New Revision: 288907
>> URL: https://svnweb.freebsd.org/changeset/base/288907
>> 
>> Log:
>>  Call sync consistently using atf_check
>> 
>>  Remove superfluous sync's
> 
> You should not need to call sync() to see the results of earlier namespace
> changes (file create, rename, delete, etc.), even for NFS when looking on the
> same client that made the namespace change.
> 
> Are you doing this to force mtime updates?  You should not need sync() for
> that on UFS (ufs_getattr() forces any pending lazy timestamp updates).  You
> would for NFS (not sure about ZFS).
> 
> Whatever the reason for the syncs, I think it warrants a comment.

You’re right about it not being clear as to why they’re there.

I ran into issues earlier on when developing the test cases, but it might have been how I wrote them, along with bugs I fixed while developing them.

I’ll retest without the syncs. Depending on the outcome I’ll either remove them entirely or comment on why they’re there. I’ll probably do a combination of both if I run into issues.

Thanks :)!
-NGie

PS I run my tests with UFS and atime on, mostly, but I also use ZFS periodically. My work system runs ZFS, but I’m a few months behind because of deliverables in flight and having to take down the system/risk an upgrade with the recent churn in ZFS.