svn commit: r288966 - head/share/mk

[Bryan Drewery]

On 11/18/15 7:53 PM, Simon J. Gerraty wrote:
> Bryan Drewery <bdrewery at FreeBSD.org> wrote:
>> > As for the actual change in local.autodep.mk, I don't think it is needed
>> > or right since bsd.lib.mk and bsd.prog.mk already do exactly the same
>> > thing via ${OBJS}: ${SRCS:M*.h} if .depend is not yet generated. This
>> > does work in meta mode as I ran into a failure due to it before r291046
>> > (I had removed the libbfd/Makefile.depend.host for other testing). It's
>> > also hooked in far too late and orthogonally to the OBJS in the graph
>> > that need the headers.
> Forgive me; what is "it" in the last sentence?
> 
> It is never too late to add a dependency.
> It can easily be too late to add a value to a variable - to affect
> dependencies.

"It" is the header dependency. buildfiles is too late. This would need
to be on OBJS (which bsd.prog.mk/bsd.lib.mk already do, to ensure the
header is part of the object's dependency tree) or beforebuild. Putting
it on buildfiles is a separate part of the dependency tree than the
objects are in.

-- 
Regards,
Bryan Drewery