svn commit: r290900 - head/sbin/restore

Alexey Dokuchaev danfe at FreeBSD.org
Mon Nov 16 02:08:42 UTC 2015


On Mon, Nov 16, 2015 at 01:29:59AM +0000, John-Mark Gurney wrote:
> New Revision: 290900
> URL: https://svnweb.freebsd.org/changeset/base/290900
> 
> Log:
>   If you backup a large file that is mostly holes, previously we'd issue
>   a seek for every block...  For large (Exabyte sized files) this would
>   issue lots of unneeded seeks, so combine them...
> 
> [...]
> @@ -938,14 +953,15 @@ getfile(void (*datafill)(char *, long), 
>  {
>  	int i;
>  	off_t size;
> +	long seekpos;

Briefly reading through tape.c, it looks like `long' is abused here (and in
other places).  IMHO we should try to fix these bugs, not add new misuses.

./danfe


More information about the svn-src-head mailing list