svn commit: r283275 - head/sys/dev/fdt

Oleksandr Tymoshenko gonzo at freebsd.org
Fri May 22 18:47:51 UTC 2015


> On May 22, 2015, at 3:53 AM, Andrew Turner <andrew at fubar.geek.nz> wrote:
> 
> On Fri, 22 May 2015 02:00:45 +0000 (UTC)
> Oleksandr Tymoshenko <gonzo at FreeBSD.org> wrote:
> 
>> Author: gonzo
>> Date: Fri May 22 02:00:44 2015
>> New Revision: 283275
>> URL: https://svnweb.freebsd.org/changeset/base/283275
>> 
>> Log:
>>  Add helper method fdt_find_child to make access to child nodes
>> easier. 
>>  Some FDT nodes have complex properties organized as a child
>> sub-nodes (e.g. timing for LCD panel) we need easy way to obtain
>> handles for these sub-nodes
> 
> Why is this named fdt_find_child? It's not fdt specific so should be
> named something like ofw_bus_find_child and live in
> sys/dev/ofw/ofw_bus_subr.c.
> 
> In general we are trying to move away from the fdt_ functions unless
> absolutely needed.

I wasn't aware of this. Thanks for pointing out, will change name 
later today or tomorrow. 



More information about the svn-src-head mailing list